Expect_called fn addition

[danilito19]

• This PR adds expect_call helper function, tests, up version, documentation, etc.

May need some suggestions for improvements, especially for the last test (commented out) that doesn't pass when wrapped in either test_that or describe.

I"ve also added .DS_Store to .gitignore.

[danilito19]

I ran test("~/dev/testthatsomemore") before pushing the branch and tests passed. What's the best way to figure out why my tests wouldn't pass travis?

[robertzk]

@danilito19 What was the problem?

[robertzk]

@danilito19 Opening up the travis build shows the failures

1. Error: it finds called function (@test-expect_called.R#6) -------------------
could not find function "duplicate"
1: expect_true(expect_called(base::sum, f())) at testthat/test-expect_called.R:6
2: expect(identical(as.vector(object), TRUE), sprintf("%s isn't true.", lab), info = info)
3: as.expectation(exp, ..., srcref = srcref)
4: identical(as.vector(object), TRUE)
5: as.vector(object)
6: expect_called(base::sum, f())
2. Error: it detects function was not called (@test-expect_called.R#11) --------
could not find function "duplicate"
1: expect_true(expect_called(base::sum, f(), was_called = FALSE)) at testthat/test-expect_called.R:11
2: expect(identical(as.vector(object), TRUE), sprintf("%s isn't true.", lab), info = info)
3: as.expectation(exp, ..., srcref = srcref)
4: identical(as.vector(object), TRUE)
5: as.vector(object)
6: expect_called(base::sum, f(), was_called = FALSE)
3. Error: Package setting works (@test-expect_called.R#16) ---------------------
could not find function "duplicate"
1: expect_true(expect_called(sum, f(), "base")) at testthat/test-expect_called.R:16
2: expect(identical(as.vector(object), TRUE), sprintf("%s isn't true.", lab), info = info)
3: as.expectation(exp, ..., srcref = srcref)
4: identical(as.vector(object), TRUE)
5: as.vector(object)
6: expect_called(sum, f(), "base")

You have to define the duplicate function (might require changes to src/ ).

[danilito19]

@robertzk could you point me to where you got that stack? All I see is where the tests failed. Where in travis could I find that (for next time)?

[robertzk]

@danilito19 I think it's hidden by default unfortunately - you have to scroll to the bottom and click after_failure

[robertzk]

@danilito19 Don't forget to devtools::document() or the NAMESPACE file won't be updated. That should fix tests.

[danilito19]

@peterhurford another pretend_now_is test failure

Error: Test failed: 'it can pretend it's 5 seconds ago'
Not expected: Sys.time() not equal to five_s_ago
Mean absolute difference: 0.001155853.

I'll look into it

[coveralls]

Coverage decreased (-1.5%) to 98.485% when pulling b1cefc1 on danilito19:exp-called into e68b47b on robertzk:master.

[peterhurford]

This still happening?