Add QOI metric plugin #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertu94
reviewed
Jan 5, 2026
Owner
robertu94
left a comment
robertu94
left a comment
There was a problem hiding this comment.
Can you please send a copy of $BUILD_DIR / pressio_manual_register.cc to confirm that it is being registered correctly.
| libpressio_plugin_file(io/posix.cc) | ||
| libpressio_plugin_file(domains/malloc.cc) | ||
| libpressio_plugin_file(domains/nonowning.cc) | ||
| libpressio_plugin_file(metrics/qoi.cc) |
robertu94
requested changes
Jan 5, 2026
| libpressio_optional_component(copy_template "build the numpy io plugin" /io/copy_template.cc) | ||
| libpressio_optional_component(size "build the size metrics plugin" /metrics/size.cc) | ||
| libpressio_optional_component(time "build the time metrics plugin" /metrics/time.cc) | ||
| libpressio_optional_component(time "build the qoi metrics plugin" /metrics/qoi.cc) |
Owner
There was a problem hiding this comment.
this should be
libpressio_optional_component(qoi "build the qoi metrics plugin" /metrics/qoi.cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added qoi.cc and CMakeLists.txt.
I am not working with any external values(JSON format) extracted from Python scripts yet. I am working on getting the qoi integrating to Pressio so that I can run with the command "pressio....qoi...".