Skip to content

Fix 0.6+ compatibility for push & pop array member functions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alpdeniz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 0.6+ compatibility for push & pop array member functions #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contracts/UintSet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pragma solidity ^0.5.0;
pragma solidity ^0.6.0;

/**
* @notice Key sets with enumeration and delete. Uses mappings for random
Expand All @@ -23,7 +23,8 @@ library UintSet {
*/
function insert(Set storage self, uint key) internal {
require(!exists(self, key), "UintSet: key already exists in the set.");
self.keyPointers[key] = self.keyList.push(key)-1;
self.keyPointers[key] = self.keyList.length;
self.keyList.push(key);
}

/**
Expand All @@ -42,7 +43,7 @@ library UintSet {
self.keyList[rowToReplace] = keyToMove;
}
delete self.keyPointers[key];
self.keyList.length--;
self.keyList.pop();
}

/**
Expand Down