[Magik-version] Make check file-existence optional#278
Open
reinierkof wants to merge 1 commit intoroadrunner1776:masterfrom
Open
[Magik-version] Make check file-existence optional#278reinierkof wants to merge 1 commit intoroadrunner1776:masterfrom
reinierkof wants to merge 1 commit intoroadrunner1776:masterfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for the file-exist-p to be skipped on the small world versions entries.
Since this function is c-compiled and can hang for a minute on network disks sometimes It can be nice to turn off when a file is not reachable.
Since we don't really check whether this is a valid smallworld installation it shouldn't matter much.
Besides that I added an error when on an entry can't find an alias file in the installation. I think this should be added regardless of the custom.