Open
Conversation
…nd aliyah.json with API queries to the @hebcal/leyning package
coolreader18
force-pushed
the
web-and-stuff
branch
from
30b19a2 to
c1444f5
Compare
coolreader18
force-pushed
the
web-and-stuff
branch
from
c1444f5 to
4361e90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sent an email directly about this a few months ago but perhaps it missed your inbox-- in any case, just wanted to put this up as a PR just-in-case. This branch is based on #2.
Over the past year and a half or so, I've been working on this fork, which makes a bunch of improvements - originally, I was just looking to add web support (that link goes to a fully working web version of the app!), but I also added a calendar of readings, support for triennial readings (text AND audio), megillot, mincha readings, android support, and a dark mode; folded the trope recordings into this app to let you click on it from the reading screen; and switched from the WLC to Miqra According to the Masora. I am pretty sure I broke the iOS version, though, since I don't have a mac that I can test with. I'm not really sure what the process would be for merging this would be - it's obviously a whole lot of changes, and at a certain point I started treating it more like a clean fork than a branch that I'd merge back in (switched to typescript, added autoformatting, etc). I do think it'd be neat if the web version was at web.pockettorah.com or something like that, since I'm currently just hosting it on the github pages site for my repo.