Skip to content

Conversation

@CoolCat467
Copy link
Contributor

In this pull request, we switch the project configuration to use pyproject.toml and fix a syntax error in the typing stubs I encountered using mypy on a project that uses this project.

@Pasu4
Copy link

Pasu4 commented Dec 14, 2025

It may be better to split these two changes into separate PRs, so in case switching to pyproject takes further discussion or is not wanted, the fix for the syntax error can still go through (or go through faster than otherwise).

@CoolCat467
Copy link
Contributor Author

That's a good idea, will split this into two PRs, leaving this one for pyproject.toml, and will make another one for the syntax error that is immediately impacting us.

@CoolCat467 CoolCat467 force-pushed the fix-typing-and-use-pyproject-toml branch from 79faf3c to f418044 Compare December 14, 2025 02:50
@rnag
Copy link
Owner

rnag commented Dec 14, 2025

@CoolCat467 Thanks for working on this PR! This change breaks CI because tox is now reading setup.cfg instead of pyproject.toml.
Since the PR removed tox.ini, can you also update the GitHub Actions job to explicitly install tox 4.x (and the gh plugin if needed) so tool.tox.legacy_tox_ini is picked up correctly?

@rnag rnag self-requested a review December 14, 2025 22:11
@CoolCat467
Copy link
Contributor Author

Removed setup.cfg and moved all configuration it contained to pyproject.toml

@rnag
Copy link
Owner

rnag commented Dec 15, 2025

@CoolCat467 Thanks! It looks like there are some last-minute merge conflicts but they should be trivial - setup.py was removed for example. Are you able to take a look when you have a chance?

I would normally try to resolve them, but I'm seeing it grayed out with an error:

These conflicts are too complex to resolve in the web editor.

@CoolCat467
Copy link
Contributor Author

Sure thing

@rnag
Copy link
Owner

rnag commented Dec 18, 2025

@CoolCat467 LGTM! Thanks for your contribution on this.

@rnag rnag merged commit 0f27c9d into rnag:main Dec 18, 2025
6 checks passed
@rnag
Copy link
Owner

rnag commented Dec 18, 2025

@CoolCat467 These changes should be live as of 0.36.3. I've also credited you in the release notes. Thanks for your help on this!

@CoolCat467 CoolCat467 deleted the fix-typing-and-use-pyproject-toml branch December 19, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants