-
-
Notifications
You must be signed in to change notification settings - Fork 31
Switch to use pyproject.toml and fix typing issue
#213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It may be better to split these two changes into separate PRs, so in case switching to pyproject takes further discussion or is not wanted, the fix for the syntax error can still go through (or go through faster than otherwise). |
|
That's a good idea, will split this into two PRs, leaving this one for |
Split off into rnag#214
79faf3c to
f418044
Compare
|
@CoolCat467 Thanks for working on this PR! This change breaks CI because tox is now reading |
… versions Also update makefile
`uv` works in parallel and runs far faster
|
Removed |
|
@CoolCat467 Thanks! It looks like there are some last-minute merge conflicts but they should be trivial - I would normally try to resolve them, but I'm seeing it grayed out with an error:
|
|
Sure thing |
|
@CoolCat467 LGTM! Thanks for your contribution on this. |
|
@CoolCat467 These changes should be live as of |
In this pull request, we switch the project configuration to use
pyproject.tomland fix a syntax error in the typing stubs I encountered using mypy on a project that uses this project.