Skip to content

Fix/geolocation bug #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmnppt merged 2 commits into from
Apr 7, 2025
Merged

Fix/geolocation bug #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc304d
feat: Initialize geolocation state structure in geolocationSlice
Apr 7, 2025
74ccaee
feat: Implement geoLocation dispatch within useEffect for improved va…
Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions bs3/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,18 @@ import { Outlet } from 'react-router-dom';
import { useDispatch } from 'react-redux';
import { setLocation } from './app/geolocatorSlice';
import useGeoLocationCheck from './api/geolocation';
import { useEffect } from 'react';

function App() {

const dispatch = useDispatch();
const geoLocation = useGeoLocationCheck();
dispatch(setLocation(geoLocation));
const geoLocation = useGeoLocationCheck(); // Custom hook

// Use useEffect to dispatch the action only when geoLocation is valid
useEffect(() => {
if (geoLocation) {
dispatch(setLocation(geoLocation));
}
}, [dispatch, geoLocation]);

return (
<div className="App">
Expand Down
6 changes: 5 additions & 1 deletion bs3/src/app/geolocatorSlice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { createSlice } from '@reduxjs/toolkit';
export const geolocationSlice = createSlice({
name: 'geolocation',
initialState: {
location: null,
location: {
loaded: false,
coordinates: { lat: null, lng: null },
local: false,
}
},
reducers: {
setLocation: (state, action) => {
Expand Down