-
Notifications
You must be signed in to change notification settings - Fork 3
Add ability to specifiy cert_path and key_path #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@rlenglet could you review please? i would like to use this with centos and this is one possible solution. |
| { | ||
| "operatingsystem": "Ubuntu" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies key is indeed required.. see https://puppet.com/docs/puppet/7.1/modules_metadata.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say so, otherwise I wouldn't put it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please note this is 3 years old merge request, which I am not able to support anymore as I don't remember this kind of details.
|
@rlenglet Checked back a year later to check on this PR which is still open, which it is :) I created a similar change last year for my own use, let me know if you'd prefer this solution and I'll create a PR - |
|
@nambrosch The name of the parameters doesn't matter much. But please address my comment from 15 months ago. 😀 |
The PR from 2017 belongs to @skrivy so was hoping they would take responsibility. |
Added ability to specify cert_path and key_path.