Add focused coverage tests for plot and diagnostics#19
Open
ArslanBatyrov wants to merge 5 commits intorkillick:mainfrom
Open
Add focused coverage tests for plot and diagnostics#19ArslanBatyrov wants to merge 5 commits intorkillick:mainfrom
ArslanBatyrov wants to merge 5 commits intorkillick:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two focused test files to increase coverage in EnvCpt:
test-plot-extra.Rforplot.envcpt()argument validation and behaviourtest-diagnostics-extra.RforAIC/AICweightsdiagnostics behaviourI ran the full local test suite with
NOT_CRAN=true, and it completed with no failures.I also compared package coverage on upstream
mainversus this branch usingcovr::package_coverage().Coverage summary:
R/diagnostics.Rsrc/C_cptreg.cR/CptReg.RR/envcpt.RWhile adding diagnostics tests, I also noticed a likely separate bug in
BIC.envcptwhennis supplied explicitly.Reproducible example: