Force tcl files to have lf line endings inside tclkit. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py would produce crlf if on Windows. Files may be read directly using mk4tcl/uplevel commands without automatic \<newline> substitution. \<newline> occur inside mk4vfs.tcl. The resulting error is silently suppressed, but leads to a not functional access to the vfs like the one decribed here http://kitcreator.rkeene.org/fossil/tktview?name=3428b6ae06
|
I had this exact problem building Tclkits with MSYS2/MINGW on Windows. This patch worked for me. |
|
This fix worked for me as well using MSYS2 UCRT64. @rkeene please merge this in when you are able. Or if you'd like another approach on Fossil please let me know and I'd be happy to submit a patch there. Thank you! @wtschueller Thank you for fixing this issue it would have taken a while for me to track it down otherwise. |
|
@rkeene I have included the fix with the drive-by patch associated with the issue TclKits with Tk targetting Windows blurry due to improper high-dpi scaling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, fcopy would produce crlf if on Windows.
Files may be read directly using mk4tcl/uplevel commands without automatic <newline> substitution.
<newline> occur inside mk4vfs.tcl. The resulting error is silently suppressed, but leads to a not
functional access to the vfs like the one decribed here http://kitcreator.rkeene.org/fossil/tktview?name=3428b6ae06