Closed
Conversation
Contributor
|
I have similar changes as well, but with more extras. However currently these depends on #64 in my repo. I probably could clean this up to make it independent, but it is almost exactly the same as yours. |
Owner
Author
|
That sounds great! I merged your other PR, so feel free to open a new one. |
Owner
Author
|
Closing. #69 covered this work and took it further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty small change in the hot path. It replaces the use of a :lists.foreach call with a recursive function. It also splits out
fetch_measurement/3into separate function heads, though there's no noticeable change in performance there.The improvements, as measured by tprof, using a simple microbenchmark