Patch extensions directly #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quezion
approved these changes
Nov 9, 2020
Collaborator
Quezion
left a comment
Quezion
left a comment
There was a problem hiding this comment.
Given the current parsing implementation, this seems conformant to the RFC. It seems to match style & includes tests.
I approve. I'd normally merge this -- but since this process is young... @rkaippully is this a satisfactory PR for you?
If so, I will merge PRs of this quality in the future & only ask you for release.
Speaking of, can you please perform a release after this PR?
Owner
|
In fact, this is wrong according to RFC. The syntax at https://tools.ietf.org/html/rfc7644#page-21 says that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an extension of the form
a:b:ccannot be patched directly, because the path will be interpreted as an attributecin extensiona:b. Attributes within the extension can be patched, but not the extension itself.This PR adds support for patching extensions, by looking for them in the
:schemasfield of the object being patched. E.g. ifa:b:cis in:schemas, it will be treated as an extension, otherwise it will be treated as an attributecin extensiona:b.