Skip to content

Conversation

@rjvim
Copy link
Owner

@rjvim rjvim commented Apr 17, 2025

  • Modified tap detector to only show the M icon without opening the panel
  • Fixed issue where re-enabling via tap would open the panel instead of just showing the icon
  • Ensured panel state remains closed when toggling via tap feature
  • Maintains backward compatibility with existing functionality
  • Addresses user frustration when working on websites

- Modified tap detector to only show the M icon without opening the panel
- Fixed issue where re-enabling via tap would open the panel instead of just showing the icon
- Ensured panel state remains closed when toggling via tap feature
- Maintains backward compatibility with existing functionality
- Addresses user frustration when working on websites
@rjvim rjvim added the release Create a release when this pr is merged label Apr 17, 2025
@rjvim
Copy link
Owner Author

rjvim commented Apr 17, 2025

fix: prevent panel from opening when using tap feature #69

This fix assumes that the bug is in with tap feature, where it's not.

Open console and run window.MetaScan.enableOrDisable(true); -> The panel will open.

I think the bug is just this one line:

stateManager.updateState({ isOpen: true });

Where we say:

      // Also update the UI state to open the panel
      stateManager.updateState({ isOpen: true });

If we remove above line or make it false, it should fix the auto panel problem

@rjvim rjvim merged commit 90f15d5 into main Apr 17, 2025
2 checks passed
@rjvim rjvim deleted the fix-tap-feature-panel-behavior branch April 17, 2025 11:35
@github-actions
Copy link

🚀 PR was released in v0.13.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 17, 2025
@github-actions
Copy link

🚀 PR was released in v0.13.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a release when this pr is merged released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants