Skip to content

fix: make tap feature opt-in and fix panel opening bug #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rjvim wants to merge 1 commit into from
Closed

fix: make tap feature opt-in and fix panel opening bug #64

rjvim wants to merge 1 commit into from

Conversation

@rjvim
Copy link
Owner

@rjvim rjvim commented Apr 17, 2025

  • Fix where tap activation opens entire panel instead of just showing the "M" icon
  • Make tap feature opt-in via new data-enable-tap-feature attribute
  • Update MetaScanOptions interface to include enableTapFeature option
  • Enhance error handling and add detailed logging for debugging
  • Add test/tap-feature-test.html to verify functionality

Closes #63

@rjvim
fix: make tap feature opt-in and fix panel opening bug
288e51f 
- Fix where tap activation opens entire panel instead of just showing the "M" icon
- Make tap feature opt-in via new data-enable-tap-feature attribute
- Update MetaScanOptions interface to include enableTapFeature option
- Enhance error handling and add detailed logging for debugging
- Add test/tap-feature-test.html to verify functionality

Closes #63
@rjvim rjvim added the release Create a release when this pr is merged label Apr 17, 2025
@rjvim rjvim mentioned this pull request Apr 17, 2025
Closed
@rjvim
Copy link
Owner Author

rjvim commented Apr 17, 2025

Test Cases:

data-auto-enable="true"

This should show M icon by default

data-auto-enable="false" && data-enable-tap-feature="false"

This shouldn't show M icon by default

  • Even when we click 5 times on page, M shouldn't activate
  • But if we run window.MetaScan.enableOrDisable(true); from console, it should show M
  • If we run window.MetaScan.enableOrDisable(false); from console, it should hide M

data-auto-enable="false" && data-enable-tap-feature="true"

This shouldn't show M icon by default

  • When we click 5 times on page, M should become visible. Also, here only M should be visible, it shouldn't open the panel itself.
  • Now, When we click 5 times on page, M should hide

@rjvim rjvim closed this Apr 17, 2025
@rjvim rjvim deleted the tap-feature-opt-in branch April 17, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release Create a release when this pr is merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: MetaScan Panels opens completely on 3-5 clicks

2 participants

@rjvim