Permit IPv6 addresses in SMTP transport #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Seperate regexes for DNS, IPv4 and IPv6 in the port in host detection routine - Add tests for the port in host detection routine - Change host parameter documentation to describe supported address types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 usage is becoming more prevalent now. My VPSs from various providers all have IPv6 addresses by default and are routing traffic over IPv6 by default. I'd like to be able to specify an IPv6 address as the SMTP host. To do this, the routine that detects the usage of a port in the hostname needs to be a little cleverer, as IPv6 addresses include the colon as a group separator.
Thanks!