Improve test reliability with data-testid selectors #6
+14
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored component tests to use
data-testidattributes for DOM element selection instead of relying on generic selectors like tag names and class names. This improves test reliability and maintainability by making assertions more explicit and less brittle.Key Changes
ImageBackgroundtest to usedata-testidselectors for both the component and its child span elementdata-testidattributes to Text components and child elementsdata-testidselector and explicitly check classList instead of relying on querySelector with class selectorBenefits
data-testidattributes make it explicit what elements are being testedhttps://claude.ai/code/session_012rYreUmQGJAkR377wVFM8N