debug_console: Update to match ratified version#22
Merged
dgreid merged 1 commit intorivosinc:mainfrom May 10, 2025
Merged
Conversation
The ratified version of the debug console supports a read and single byte write. Additionally, the PutString function was named "Write". Bump the version string as this is a breaking change. Signed-off-by: Dylan Reid <dgreid@rivosinc.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the debug console implementation to match the ratified version by renaming the PutString function to Write, introducing new functionality for reading and single-byte writing, and bumping the version as a breaking change.
- Renamed PutString to Write and added a new addr_hi field.
- Introduced Read and WriteByte variants to support the ratified interface.
- Updated API usage and bumped Cargo version to 0.2.0.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/debug_console.rs | Updated enum variants and trait implementations to align with spec. |
| src/api/debug_console.rs | Adjusted function call to use the new Write variant with addr_hi. |
| Cargo.toml | Bumped version number to reflect the breaking change. |
Comments suppressed due to low confidence (1)
src/api/debug_console.rs:7
- The comment contains a spelling error: 'platfrom' should be 'platform'.
/// Prints the given string in a platfrom-dependent way.
atishp04
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ratified version of the debug console supports a read and single byte write. Additionally, the PutString function was named "Write".
Bump the version string as this is a breaking change.