Conversation
187094b to
e785c66
Compare
fb88bf5 to
f0c904d
Compare
e785c66 to
af0a552
Compare
8aa1d92 to
518eb28
Compare
af0a552 to
db47b69
Compare
These tests first startup qemu with the image from the dump, then run a humility command. This test both running in qemu, as well as the qemu core. The included tests are `qemu-readvar`, `qemu-dump`, `qemu-halt`, `qemu-resume`. The autogenerated cases are included in the following commit.
This is needed to run the qemu checks within `cargo test`.
db47b69 to
5acfaa5
Compare
|
Hi @beezow! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This adds 4 additional tests that utilize the qemu core in humility. I added
qemu-dump,qemu-readvar,qemu-halt,qemu-resume. While the results of halt and resume are not verified, they do ensure there are no panics. I did not replicate all of the commands, since I think we only need to exercise the various parts of the core; the commands themselves should already be verified via the dump core tests.Just a heads up this PR contains lots of auto generated test output.
This depends on #36.