Skip to content

Use qemu to run additional tests.#38

Open
beezow wants to merge 5 commits intorivos/mainfrom
dev/drew/qemu_test
Open

Use qemu to run additional tests.#38
beezow wants to merge 5 commits intorivos/mainfrom
dev/drew/qemu_test

Conversation

@beezow
Copy link

@beezow beezow commented Nov 29, 2022

This adds 4 additional tests that utilize the qemu core in humility. I added qemu-dump, qemu-readvar, qemu-halt, qemu-resume. While the results of halt and resume are not verified, they do ensure there are no panics. I did not replicate all of the commands, since I think we only need to exercise the various parts of the core; the commands themselves should already be verified via the dump core tests.

Just a heads up this PR contains lots of auto generated test output.

This depends on #36.

@beezow beezow force-pushed the dev/drew/qemu_test branch from 187094b to e785c66 Compare November 29, 2022 04:57
@beezow beezow requested a review from a team November 29, 2022 05:01
@beezow beezow marked this pull request as ready for review November 29, 2022 05:01
@beezow beezow force-pushed the dev/drew/qemu_test branch from e785c66 to af0a552 Compare November 29, 2022 05:40
@beezow beezow force-pushed the dev/drew/qemu_and branch 3 times, most recently from 8aa1d92 to 518eb28 Compare November 30, 2022 01:39
Base automatically changed from dev/drew/qemu_and to rivos/main November 30, 2022 02:26
@beezow beezow force-pushed the dev/drew/qemu_test branch from af0a552 to db47b69 Compare December 2, 2022 23:45
These tests first startup qemu with the image from the dump, then run a
humility command.  This test both running in qemu, as well as the qemu
core.  The included tests are `qemu-readvar`, `qemu-dump`, `qemu-halt`,
`qemu-resume`.

The autogenerated cases are included in the following commit.
This is needed to run the qemu checks within `cargo test`.
@beezow beezow force-pushed the dev/drew/qemu_test branch from db47b69 to 5acfaa5 Compare December 2, 2022 23:50
@meta-cla
Copy link

meta-cla bot commented Jan 14, 2026

Hi @beezow!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant