Conversation
zherendong
requested review from
a team,
FawazTirmizi,
beezow and
furquan-rivos
beezow
left a comment
beezow
left a comment
There was a problem hiding this comment.
Did you test this on actual board? I think we should also verify arm still works. I also kind of feel like we should squash these first 3 commits, as they are just changes to work with the updated interface. I think it will not build unless you use the last commit, right?
| core.write_core_reg( | ||
| Into::<probe_rs::CoreRegisterAddress>::into(reg_id), | ||
| Into::<probe_rs::RegisterId>::into(reg_id), | ||
| value as u32, |
There was a problem hiding this comment.
We should only cast to a u32 on a 32bit platform. I think this function is templated, so we can call a different version depending on our architecture.
|
|
||
| self.halt_and_read(|core| { | ||
| rval = core.read_word_32(addr)?; | ||
| rval = core.read_word_32(addr.into())?; |
There was a problem hiding this comment.
We should probably implement read_word_64 too. The default implementation just calls this function twice.
No I haven't. Will do so tomorrow. I agree we should also verify arm.
Correct. They might need to be squashed. |
zherendong
force-pushed
the
dev/zheren/probe-rs_bump_0.13
branch
from
ceb9597 to
eec4e07
Compare
zherendong
changed the base branch from
rivos/main
to
dev/zheren/bump_rust_toolchain_version
zherendong
force-pushed
the
dev/zheren/probe-rs_bump_0.13
branch
from
eec4e07 to
fdca14d
Compare
zherendong
force-pushed
the
dev/zheren/bump_rust_toolchain_version
branch
from
cb4a1c4 to
d88d7fe
Compare
zherendong
force-pushed
the
dev/zheren/probe-rs_bump_0.13
branch
3 times, most recently
from
3ea5821 to
5fc5daf
Compare
|
Bumped to upstream master branch
|
zherendong
force-pushed
the
dev/zheren/probe-rs_bump_0.13
branch
from
2dcee76 to
8831295
Compare
- At least one change we need is not released with v0.13.0. Upstream's release mechanism is not rigorous and everything on master branch is tested and passed upstream's CI. So instead of using v0.13.0, we will use latest master branch. - updated implementations to reflect latest upstream changes(upstream did many refactorings) - rusb and libusb1-sys patch also need to be updated to a newer version as latest probe-rs is dependent on newer versions of rusb - deleted out-of-date comments
zherendong
force-pushed
the
dev/zheren/probe-rs_bump_0.13
branch
from
f3f73f3 to
1a7d105
Compare
|
Hi @zherendong! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
3 participants
Upstream probe-rs v0.13.0 has
probe-rs in use: https://github.com/rivosinc/probe-rs/tree/dev/zheren/humility_bump
I also updated rusb: https://github.com/rivosinc/rusb/tree/dev/zheren/test_bump_probe-rs