Skip to content

Fail to generate large amount of subnets due to Integer Overflow #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonerni wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fail to generate large amount of subnets due to Integer Overflow #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ece32
- Fixed Bug when generating a large amount of subnets from a large su…
simonerni Jun 13, 2019
1bf65c3
Bump Version number to 1.0.3
simonerni Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ library for Python. Examples in this readme are taken from [here](https://netadd
## Usage
Add the following to your build.sbt:

`libraryDependencies += "com.risksense" % "ipaddr_2.12" % "1.0.2"`
`libraryDependencies += "com.risksense" % "ipaddr_2.12" % "1.0.3"`

## Tutorial
* [IpAddress](#ipaddress)
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ lazy val root = (project in file("."))
.settings(
name := "ipaddr",
organization := "com.risksense",
version := "1.0.2",
version := "1.0.3",
scalaVersion := "2.12.6",
scalacOptions ++= Seq(
"-feature",
Expand Down
3 changes: 1 addition & 2 deletions src/main/scala/com/risksense/ipaddr/IpNetwork.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ class IpNetwork private[ipaddr](
if (prefix < 0 || prefix > this.ipAddr.width || prefix < this.mask) {
Nil
} else {
val maxSubnets = scala.math.pow(2, this.ipAddr.width - this.mask).toInt /
scala.math.pow(2, this.ipAddr.width - prefix).toInt
val maxSubnets = scala.math.pow(2, prefix - this.mask).toInt
val countNew = count match {
case 0 => maxSubnets
case _ => count
Expand Down
6 changes: 6 additions & 0 deletions src/test/scala/com/risksense/ipaddr/IpNetworkTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ class IpNetworkTest extends UnitSpec {
net1.subnet(26).size should be(4) // scalastyle:ignore
net1.subnet(26).size should be(4)
net1.subnet(33) should be(Nil)

val largeAmountOfSubnets = net6.subnet(17, 100000)

largeAmountOfSubnets.size should be (100000)
largeAmountOfSubnets.forall(s => s.mask == 17) should be(true)

}

it should "perform next operation" in {
Expand Down