Skip to content

Conversation

@kosiken
Copy link
Contributor

@kosiken kosiken commented Jan 30, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 30, 2026 07:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow to incorporate an explicit versioning command in the Sigil publish step before publishing to npm.

Changes:

  • Adds a shell block to read packages/sigil/package.json’s version and run npm version before bun publish for Sigil.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 29 to 30
npm version $PACKAGE_VERSION --no-git-tag-version
cd packages/sigil && bun publish --access public
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm version $PACKAGE_VERSION --no-git-tag-version is executed from the repo root, but PACKAGE_VERSION is read from packages/sigil/package.json. As written, this updates the root package.json (and potentially root lockfiles) rather than the packages/sigil package, which is likely not what you want for the Sigil publish step. Run the version command within packages/sigil (or use npm --prefix packages/sigil …) so the correct package.json is updated, or remove this if versioning is already handled by bun sync.

Suggested change
npm version $PACKAGE_VERSION --no-git-tag-version
cd packages/sigil && bun publish --access public
cd packages/sigil && npm version "$PACKAGE_VERSION" --no-git-tag-version && bun publish --access public

Copilot uses AI. Check for mistakes.
Comment on lines 28 to 29
PACKAGE_VERSION=$(cat packages/sigil/package.json | jq -r .version)
npm version $PACKAGE_VERSION --no-git-tag-version
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PACKAGE_VERSION extraction uses a useless cat pipeline and the variable is unquoted when passed to npm version. Prefer jq -r '.version' packages/sigil/package.json and quote the expansion when used to avoid accidental word-splitting if the value ever contains unexpected characters.

Suggested change
PACKAGE_VERSION=$(cat packages/sigil/package.json | jq -r .version)
npm version $PACKAGE_VERSION --no-git-tag-version
PACKAGE_VERSION=$(jq -r '.version' packages/sigil/package.json)
npm version "$PACKAGE_VERSION" --no-git-tag-version

Copilot uses AI. Check for mistakes.
@kosiken kosiken closed this Jan 30, 2026
@kosiken kosiken deleted the fix/fix-deploy branch January 30, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant