You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for adding the icon, my display manager (i3) does not show any icons attached to .desktop files, so this fell under the radar here.
For the removal of $HOME, have a look in #2, there were many problems with this particular variable which is why I removed it from the build process completely (seems like some shell implementations seem to not set $HOME as a default variable).
I really don't want to remove this piece of code since I can't cover every shell environment which uses anything outside of any linux base tools (and whoami is used in the linux kernel itself which is why I used it to cover all derivates).
As for the .desktop file generation: I do not really like the approach of creating the .desktop file contents inside of an installer over having a ready-to-ship file in which only a placeholder needs to be replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like $HOME is enough, instead of
cat /etc/passwd | grep -w $current_user. I also added the missing icon in .desktop file and script generation