✨ add cache system to improve perfs on google keys fetching#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a caching system to improve performance when fetching Google's signing keys for webhook validation. The cache is optional and allows users to provide their own cache backend implementation to avoid repeated HTTP requests to Google's key endpoint.
Key Changes:
- Added a flexible cache abstraction with
CacheInterfaceandCacheConfigclasses - Integrated cache support into the
Validatorclass with fallback to HTTP fetch - Added comprehensive test coverage for cache hit, miss, and invalid data scenarios
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| google_wallet_webhook_auth/cache.py | Introduces new CacheInterface abstract class and CacheConfig dataclass for cache configuration |
| google_wallet_webhook_auth/validator.py | Adds optional cache_config parameter and implements cache check/store logic in _get_google_key() |
| tests/test_validator.py | Adds three new test cases covering cache hit, miss, and invalid cached data scenarios |
| README.md | Documents cache usage with a Django example implementation |
| pyproject.toml | Updates version from 0.1.0 to 1.0.0 |
| uv.lock | Reflects the version bump in the lock file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6dce805 to
b1c3c05
Compare
b1c3c05 to
24b1ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.