Skip to content

Conversation

@ret-1
Copy link

@ret-1 ret-1 commented Jan 5, 2025

Hi @riponazad ,

Thanks a lot for including the PyTorch implementation of TAPIR! It’s been really useful.

I ran into some issues while training and made a few changes to fix them (mainly related to tensor dimension ordering and coordinate format). These should solve the problems I faced, but since I haven’t explored the EchoTracker code in detail, I’m not sure if it will affect anything there.

btw, I also plan to create a new repo for a full training and inference pipeline of TAPIR based on your wonderful implementation ; )

Thanks again for the awesome work!

@riponazad
Copy link
Owner

Hello @ret-1,
Thanks for the compliment and contribution. Right now I am on vacation but from my instant memory the coordinate format (x, y) and (H, W) were in reverse in our ultrasound data than in TAP-Vid. So that can be the reason of your query. However, I will review asap I am back. Thanks again for the contribution and stating the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants