Open
Conversation
tamagokun
reviewed
Mar 3, 2026
Comment on lines
+82
to
+86
| if (portalEl) { | ||
| return createPortal(content, portalEl); | ||
| } | ||
|
|
||
| return content; |
Member
There was a problem hiding this comment.
if we don't have the portal, we should return null.
tamagokun
reviewed
Mar 3, 2026
| children, | ||
| }: Props) { | ||
| const [slide, setSlide] = useState(false); | ||
| const [portalEl, setPortalEl] = useState<HTMLDivElement | null>(null); |
Member
There was a problem hiding this comment.
this should be a ref, not state
tamagokun
reviewed
Mar 3, 2026
Comment on lines
+25
to
+26
| el.style.zIndex = "10000"; | ||
| el.style.position = "relative"; |
Member
There was a problem hiding this comment.
are these necessary? they might be, look down at my styles you'll notice similar zIndex stuff, but this needs to be as vanilla as possible so I don't want to add these unless we need to
Member
|
@ajp here's a good example of setting up a portal on web, close to what you have but a little more efficient: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a content div portal for toasts above our modals.