feat: Optimize source generation by using GetText #2095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize source generation by using GetText
Description
This is a small improvement I wished to send in for a while:
This way of the source text generation is better, since it internally contains a decision: if the output size is larger than the Large Object Heap limit, then it uses
LargeTextWriter, which breaks the source apart, so the LOH allocation is avoided. On the benchmark, there is no visible change, but I think it is worth it.Fixes # (issue)
Checklist