Skip to content

Conversation

@faddiv
Copy link
Contributor

@faddiv faddiv commented Nov 21, 2025

Prevent reporting derived type on mapping from source

Description

I saw this report, and it looked easy enough to fix. So here it is.
This prevents reporting if the source variable is a derived type of the argument type.

Fixes #2024

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz added the bug Something isn't working label Nov 23, 2025
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@latonz
Copy link
Contributor

latonz commented Dec 4, 2025

Rebase and we can get this merged 🥳 Thanks for your efforts!

Copy link

@EnesEfeTokta EnesEfeTokta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your arrangements are really beautiful.

@faddiv faddiv force-pushed the bugfix/dont-report-derived-type-on-map-from-source branch from a2e5ed1 to c6da2b0 Compare December 5, 2025 20:02
@faddiv
Copy link
Contributor Author

faddiv commented Dec 9, 2025

Hi @latonz ,
This can be merged.

@latonz latonz merged commit 3b26988 into riok:main Dec 9, 2025
19 checks passed
@faddiv faddiv deleted the bugfix/dont-report-derived-type-on-map-from-source branch December 25, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RMG072 false positive when using MapDerivedType and MapPropertyFromSource together

3 participants