Open
Conversation
Author
|
There's some typos I've found, so not ready to merge yet. |
Owner
|
Ah ok, when you are ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had added types for my own project, and thought I should just spin up a PR so it wouldn't get lost.
The types are based mostly on the docs. Some functions were in the tests, but missing from the docs, so they were added as well. I didn't do too much digging through the C code, so there may be more exposed functions missing from the types. I can at least confirm that all the functions tested are typed.
I added docs to the types based on the docs site when they added value.