fix crash when enabled style/inline_candidate #1048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the complex logic handles the happy path, but the indices can be wrong eg. when the preedit is a complex structure containing prompt text.
code that removes remaining code from the candidate preview is particularly dangerous.
the current fix is not perfect and can produce wrong selection range. let's improve it by adding librime APIs that provide segmented and detailed data of the composition.
Fixes #1047 #1045