Skip to content

feat: expectation of specific State type#45

Merged
rilshok merged 16 commits intodevfrom
rilshok/state-exp
Apr 6, 2025
Merged

feat: expectation of specific State type#45
rilshok merged 16 commits intodevfrom
rilshok/state-exp

Conversation

@rilshok
Copy link
Owner

@rilshok rilshok commented Apr 6, 2025

No description provided.

@rilshok rilshok requested a review from Copilot April 6, 2025 10:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • LICENSE: Language not supported
Comments suppressed due to low confidence (1)

tests/test_txt.py:22

  • [nitpick] The Japanese punctuation changed from a full-width exclamation mark to a half-width exclamation mark; ensure this change is intentional and aligns with your project’s standards for text formatting.
text = "こんにちは、世界!\nこれはテストファイルです。"

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/iokit
   checksum.py694929%18, 21, 25–44, 49–69, 76–77, 81–84, 89, 92–94
   state.py1563677%33–34, 53, 58–61, 96–99, 104, 107–108, 115, 123–125, 133, 148–149, 177–182, 187, 191–192, 197–200, 204, 216–217
src/iokit/extensions
   audio.py76495%82, 103–105, 109
   auto.py56493%75, 86–88
   enc.py87891%91, 112–116, 119–120
   tar.py26292%35, 38
   zip.py25196%32
src/iokit/storage
   local.py1529140%52–53, 55–56, 71–72, 75, 78–82, 85–89, 92, 95–100, 105–106, 109–113, 116–119, 122–125, 128, 131–133, 147–155, 158–166, 169–173, 186–193, 196–202, 205–218, 221–225, 228, 231–232
   storage.py482156%17–18, 22–23, 27–28, 32–33, 37–38, 50, 53, 56–60, 63–64, 67, 70
   web.py29583%14, 48–49, 54–55
TOTAL89822175% 

Tests Skipped Failures Errors Time
52 0 💤 0 ❌ 0 🔥 6.941s ⏱️

@rilshok rilshok requested a review from Copilot April 6, 2025 10:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • LICENSE: Language not supported
Comments suppressed due to low confidence (2)

src/iokit/storage/web.py:25

  • [nitpick] The abbreviation 'exp' may be unclear; consider renaming it to 'expected_type' for improved clarity and consistency.
    exp: type[S],

tests/test_txt.py:22

  • The exclamation mark '!' may be an inconsistent replacement for the Japanese exclamation mark '!'; verify if this change is intentional.
    text = "こんにちは、世界!\nこれはテストファイルです。"

@rilshok rilshok requested a review from Copilot April 6, 2025 10:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • LICENSE: Language not supported

@rilshok rilshok requested a review from Copilot April 6, 2025 11:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • LICENSE: Language not supported
Comments suppressed due to low confidence (1)

tests/test_txt.py:22

  • [nitpick] Consider using a full-width exclamation mark (!) for consistency in Japanese text if that is the intended style.
text = "こんにちは、世界!\nこれはテストファイルです。"

@rilshok rilshok merged commit 8335d6d into dev Apr 6, 2025
4 checks passed
@rilshok rilshok deleted the rilshok/state-exp branch April 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants