Add new algo, fix a few tests, make timings more precise, add profiler#1
Open
thomas-mckay wants to merge 8 commits intorikpg:masterfrom
Open
Add new algo, fix a few tests, make timings more precise, add profiler#1thomas-mckay wants to merge 8 commits intorikpg:masterfrom
thomas-mckay wants to merge 8 commits intorikpg:masterfrom
Conversation
added 8 commits
June 5, 2023 23:06
The previous implementation ensured side-effect-free execution by having the input list deepcopied as part of the benched function. This affects timings too much, so I moved that to the setup and used timeit.repeat(repeat=x, number=1) instead of timeit.timeit(number=x) to ensure the setup runs before each iteration. No side-effects and we bench the actual code instead of the deepcopy. I also simplified some of the code to remove redundant stuff. + some PEP8.
Don't assume the return value is a list (this fixes a couple of tests where the tested code wasn't at fault). Some tests still fail but that may be due to the tested code.
dict comps were heavier than I thought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the repo and the SO answer, it was a great help.
https://stackoverflow.com/a/76403418/3780296