add a public get_tree() method and have print_tree use it#83
Open
tupshin wants to merge 2 commits intoriker-rs:masterfrom
Open
add a public get_tree() method and have print_tree use it#83tupshin wants to merge 2 commits intoriker-rs:masterfrom
tupshin wants to merge 2 commits intoriker-rs:masterfrom
Conversation
Note that I found this useful when debugging and I didn't have access to a normal stdout.
Contributor
|
I don't think exposing a string representation of the internal state is a good idea. It would be better to just change the println! calls with debug! calls from the log crate. This way you could add a different log targets depending on your needs, without exposing internal state. |
Contributor
|
merged it into actors.rs |
Contributor
|
Hi @tupshin thanks for the input. I think you've identified a valid problem, however @hardliner66 has a valid point re not using a string representation. My concern would be larger actor systems that have several thousand or more actors and the allocation to append each actor name. Maybe there is a more effective way to solve the problem that you've identified? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I found this useful when debugging and I didn't have access to a
normal stdout.