add dynamic property data fetching and update PropertyListing component#27
Open
IngramCapa wants to merge 6 commits intorightmove:masterfrom
Open
add dynamic property data fetching and update PropertyListing component#27IngramCapa wants to merge 6 commits intorightmove:masterfrom
IngramCapa wants to merge 6 commits intorightmove:masterfrom
Conversation
…ertyListing styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new
getPropertiesDatafunction inapi/getPropertiesData.jsto fetch property data from a local API endpoint, including error handling for failed requests.Updated
api/index.jsto export the newgetPropertiesDatafunction for use throughout the codebase.Refactored
PropertyListing.jsxto use React state anduseEffectfor fetching property data via the new API function, replacing the previous dummy property data.Updated the test in
PropertyListing.spec.jsxto mock the fetch API, provide sample property data, and verify that the correct number of property cards are rendered based on the API response.