Adding api call and tests to propertyListings component#22
Open
Cm290 wants to merge 1 commit intorightmove:masterfrom
Open
Adding api call and tests to propertyListings component#22Cm290 wants to merge 1 commit intorightmove:masterfrom
Cm290 wants to merge 1 commit intorightmove:masterfrom
Conversation
Cm290
commented
Feb 16, 2025
- Replacing the dummy data with a call to the API
- Adding a loading and empty state to the component
- Adding the 'msw' library to mock the api calls in test
- Replacing 'jest-environment-jsdom' with 'jest-fixed-jsdom' as a workaround to allow the use of 'msw' (This should do the exact same thing, but reintroduces Node.js modules ooriginally replaced with polyfills in 'jest-environment-jsdom', explanation here: https://mswjs.io/docs/migrations/1.x-to-2.x/#frequent-issues)
- Corrected test to account for new implementation of api call
- Added tests for Loading state, Empty state and Error state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.