Remove root object restriction and add array tests for GetFailurePath #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix SystemTextJsonUtils.GetFailurePath
Remove root object restriction and add array tests for GetFailurePath
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback to remove inappropriate error handling and extend test coverage for non-object root JSON structures.
Changes
Removed root type restriction: Eliminated the check that threw an exception when root wasn't
StartObject. The recursiveGetFailurePathInternalalready handles all token types correctly.Added root-level array tests: 6 new test cases covering incomplete arrays at root:
[→ path"0"[1, 2,→ path"2"[{"a": 1}, {"b":→ path"1/b"[[1, 2], [3,→ path"1/1"[1, 2, 3→ path"3"Primitives at root already work correctly: incomplete strings return empty path, complete primitives throw "No error" as expected.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.