Fix serializer crash when deserializing object with a new instance #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would crash on: JsonTypeInfo metadata for type '...' was not provided by TypeInfoResolver... I still do not understand completely why this happens. It seems _something_ is initializing the TypeInfoResolver when it's not set by us, but only sometimes. I made two changes: 1. made the options readonly - this makes it from sometimes initializer to never initialized: at least it's predictable - generally seems like a bad idea to re-use mutable options across threads 2. set the TypeInfoResolver to the default one
exyi
force-pushed
the
fix-STJ-mystery-resolver-crash
branch
from
4b422b3 to
ed52957
Compare
tomasherceg
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would crash on: JsonTypeInfo metadata for type '...' was not provided by TypeInfoResolver...
I still do not understand completely why this happens. It seems something is initializing the TypeInfoResolver when it's not set by us, but only sometimes.
I made two changes: