Fixed bug when returning to SPA via back button #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
commented
Sep 19, 2025
exyi
approved these changes
Sep 28, 2025
exyi
force-pushed
the
fix/spa-back-from-pdf
branch
from
64c1d2a to
c5c960b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered the following bug:
This causes the
beforeunloadevent where we were saving the state tohistory.state. However, some fields (such as type metadata) were coming from the first SPA page and not from the last SPA page the user was interacting with.This was causing an error that the viewmodel was not found in type metadata map - it was coming from the first page and not from the last visited SPA page.
The same probably applies to
viewModelCacheId.