Skip to content

Add support for codecJsonEnabled in mock#115

Merged
riferrei merged 1 commit intoriferrei:masterfrom
passuied:feature/add-support-codec-json-enabled-mock
Mar 30, 2025
Merged

Add support for codecJsonEnabled in mock#115
riferrei merged 1 commit intoriferrei:masterfrom
passuied:feature/add-support-codec-json-enabled-mock

Conversation

@passuied
Copy link
Copy Markdown
Contributor

@passuied passuied commented Mar 24, 2025

  • Add support for codecJsonEnabled in mock
  • Also upgrade goavro library

Fixes: #116

also upgrade goavro library
@riferrei
Copy link
Copy Markdown
Owner

Thank you for this PR. Do you mind in elaborating the rationale behind it?

Why the need for the codecJsonEnabled and the goavro upgrade?

@passuied
Copy link
Copy Markdown
Contributor Author

passuied commented Mar 30, 2025

@riferrei You have added that property to switch between codec type but the mock doesn't respect it. It's useful in my tests on a separate project for the mock to respect it as I'm reusing that mock

@riferrei riferrei self-requested a review March 30, 2025 16:46
Copy link
Copy Markdown
Owner

@riferrei riferrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riferrei riferrei merged commit 66898ae into riferrei:master Mar 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for CodecJsonEnabled in mock

2 participants