Fix collection parsing when the value is null#1
Open
tgeorgel wants to merge 1 commit intoricventu:masterfrom
Open
Fix collection parsing when the value is null#1tgeorgel wants to merge 1 commit intoricventu:masterfrom
tgeorgel wants to merge 1 commit intoricventu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your work on this :)
This PR fixes the issue when a collection field is created with null as default value :
When using a Json Resource in a controller, which would convert the
settingsattribute to it's json representation, the following error is thrown :To address this issue, adding a default value to
"{}"would parse the value as an empty collection :It would be a nice idea to submit the package to packagist also.