feat: display more info in dashboard #214

r4ai · 2025-11-18T15:33:25Z

close #209

Copilot

Pull Request Overview

このPRは、スタッフ向けダッシュボードに統計情報と可視化機能を追加する機能改善です。

注文データの集計機能を実装し、サマリー統計、ステータス別分布、日次トレンドを表示
Chart.jsを使用したグラフコンポーネントを追加
新しいユースケース層とリポジトリクエリを実装

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
package.json	chart.jsとuplotの依存関係を追加（uplotは未使用）
app/usecases/getStaffDashboardData.ts	ダッシュボードデータ集計のユースケースロジック実装
app/infrastructure/domain/order/orderQueryRepositoryImpl.ts	ステータス集計と日次集計のクエリ実装を追加
app/domain/order/repositories/orderQueryRepository.ts	新しいクエリ関数の型定義とエクスポート
app/components/ui/$chart.tsx	Chart.jsラッパーコンポーネント（324行）
app/routes/staff/index.tsx	ダッシュボードページに統計カードとグラフを追加
app/routes/staff/-components/*.tsx	統計カード、ステータス分布、トレンドグラフのコンポーネント
app/style.css	uplotのCSS追加（未使用）

package.json

app/style.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 12 comments.

app/infrastructure/domain/order/orderQueryRepositoryImpl.ts

app/usecases/getStaffDashboardData.test.ts

app/usecases/getStaffDashboardData.ts

app/routes/staff/index.tsx

app/routes/staff/-components/$dailyOrdersTrendCard.tsx

app/infrastructure/domain/order/orderQueryRepositoryImpl.ts

app/usecases/getStaffDashboardData.ts

app/components/ui/$chart.tsx

Move `addDays`, `startOfDay`, `endOfDay`, `buildDateRange`, and `formatDateKey` from usecase layer to utils layer following architecture guidelines. These functions are domain-agnostic utility functions that can be reused across the application, aligning with the architecture principle that utils should contain "small general-purpose functions and simple processing that can be used anywhere." 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Consolidate order status definitions to prevent duplication across layers: - Define ORDER_STATUSES in domain layer (app/domain/order/entities/order.ts) as single source of truth - Update orderCommandRepository to reference domain definition instead of maintaining separate ALLOWED_ORDER_STATUSES - Update getStaffDashboardData to derive status values from domain definition while keeping UI-specific labels in usecase layer This ensures status changes only require updates in one location, improving maintainability and reducing risk of inconsistencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Remove duplicate date manipulation functions from test file and import from app/utils/date.ts instead. This eliminates code duplication between implementation and tests, reducing maintenance burden and risk of bugs. The shared utilities are now consistently defined in a single location. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add minimal JSDoc comments to Chart component and its types for better developer experience. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

app/components/ui/$chart.tsx

app/routes/staff/-components/$dailyOrdersTrendCard.tsx

app/routes/staff/index.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

app/utils/date.ts

app/routes/staff/-helpers/dashboardStatCards.ts

app/routes/staff/-components/dashboardStatCard.tsx

app/usecases/getStaffDashboardPageData.ts

app/routes/staff/index.tsx

app/domain/order/repositories/orderQueryRepository.ts

3w36zj6 · 2025-11-20T03:33:01Z

app/domain/order/repositories/orderQueryRepository.ts

+export type FindOrderStatusCounts = QueryRepositoryFunction<
+  Record<string, never>,
+  OrderStatusCount[]
+>
+
+export type FindDailyOrderAggregations = QueryRepositoryFunction<
+  {
+    from: Date
+    to: Date
+  },
+  OrderDailyAggregation[]
+>


配列を返す関数の型定義の命名はFindAllから始まり、PaginatedQueryRepositoryFunctionを利用して定義されます。
from, toをoffset, limitに変換するのはユースケース関数の責務です。

app/domain/order/entities/order.ts

r4ai added 10 commits November 18, 2025 01:11

feat: add chart component

5e96a5e

why not hydrated???????????????????

32e6174

wip

03aba0d

feat: use chart.js instead of uplot

e108fc3

wip

4c4a260

fix

e4226ee

fix

f8c20c8

feat: update staff dashboard charts

a5538c7

refactor

611fb2d

feat: remove total orders and revenue

208da07

r4ai requested a review from sou1118 as a code owner November 18, 2025 15:33

Copilot AI review requested due to automatic review settings November 18, 2025 15:33

r4ai requested a review from 3w36zj6 as a code owner November 18, 2025 15:33

Copilot started reviewing on behalf of r4ai November 18, 2025 15:34 View session

chore: remove package-lock.json

43fca58

Copilot finished reviewing on behalf of r4ai November 18, 2025 15:35

Copilot AI reviewed Nov 18, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

app/style.css Outdated Show resolved Hide resolved

r4ai and others added 6 commits November 19, 2025 00:37

chore: simplify chart component types

8f70134

chore: remove uplot

dba8f82

Update app/style.css

1aa0fbc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into feature/improve-dashboard

64565b2

style: apply biome

0af662b

test: add tests for getStaffDashboardData

6dc22b6

r4ai requested a review from Copilot November 19, 2025 05:14

Copilot started reviewing on behalf of r4ai November 19, 2025 05:15 View session

Copilot finished reviewing on behalf of r4ai November 19, 2025 05:19

Copilot AI reviewed Nov 19, 2025

View reviewed changes

r4ai and others added 3 commits November 19, 2025 17:44

docs(client): add JSDoc to Chart component

2f5b96a

Add minimal JSDoc comments to Chart component and its types for better developer experience. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

r4ai requested a review from Copilot November 20, 2025 01:56

Copilot started reviewing on behalf of r4ai November 20, 2025 01:56 View session

Copilot finished reviewing on behalf of r4ai November 20, 2025 01:57

Copilot AI reviewed Nov 20, 2025

View reviewed changes

app/components/ui/$chart.tsx Show resolved Hide resolved

app/routes/staff/-components/$dailyOrdersTrendCard.tsx Show resolved Hide resolved

app/routes/staff/index.tsx Outdated Show resolved Hide resolved

app/routes/staff/index.tsx Show resolved Hide resolved

r4ai and others added 4 commits November 20, 2025 11:05

Update app/routes/staff/index.tsx

aa95285

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into feature/improve-dashboard

fb7de8f

feat: allow selecting chart palette tokens

833d5d3

style: apply biome

00bca87

3w36zj6 requested changes Nov 20, 2025

View reviewed changes

3w36zj6 reviewed Nov 20, 2025

View reviewed changes

app/domain/order/entities/order.ts Show resolved Hide resolved

r4ai added 12 commits November 20, 2025 16:52

test: add unit tests for date

145950c

refactor: move order status constants

40d8215

refactor: narrow order query type exports

cf7edc4

refactor: paginate daily order aggregations

592cebe

refactor: inline staff dashboard stat card

11fb0e7

refactor: inline dashboard stat cards builder

e318ed2

refactor: prioritize staff dashboard summary

43df231

test: add staff dashboard integration and e2e

ef9a414

refactor: rename staff dashboard page data usecase

1a7cd83

test: extend date util coverage

1e72e0c

fix: correct dashboard daily aggregation limit

af68602

style: apply biome

576434c

3w36zj6 reviewed Nov 20, 2025

View reviewed changes

app/domain/order/entities/order.ts Outdated Show resolved Hide resolved

r4ai added 2 commits November 21, 2025 23:34

refactor: make OrderStatus private

9e83de6

refactor: refine daily order aggregation date range

ce6235e

sou1118 approved these changes Nov 21, 2025

View reviewed changes

3w36zj6 self-requested a review November 22, 2025 00:00

3w36zj6 approved these changes Nov 22, 2025

View reviewed changes

3w36zj6 marked this pull request as draft November 22, 2025 02:18

feat: display more info in dashboard #214

Are you sure you want to change the base?

feat: display more info in dashboard #214

Uh oh!

Conversation

r4ai commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

3w36zj6 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants