Skip to content

Fix for 'dirty' error caused by scroll notifications during layout #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrickWulfe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for 'dirty' error caused by scroll notifications during layout #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
821a117
Fix for 'dirty' error caused by scroll notifications during layout
Dec 18, 2023
e06e964
Fix for 'dirty' state caused by setState during build
Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/src/scroll_shadow.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/// [ScrollShadow] class
library flutter_scroll_shadow;

import 'dart:async';

import 'package:flutter/material.dart';

/// Wraps a scrollable child in `ScrollShadow`s.
Expand Down Expand Up @@ -63,14 +65,18 @@ class _ScrollShadowState extends State<ScrollShadow> {

set reachedStart(final bool value) {
if (_reachedStart == value) return;
setState(() => _reachedStart = value);
scheduleMicrotask(() {
setState(() => _reachedStart = value);
});
}

bool get reachedEnd => _reachedEnd;

set reachedEnd(final bool value) {
if (_reachedEnd == value) return;
setState(() => _reachedEnd = value);
scheduleMicrotask(() {
setState(() => _reachedEnd = value);
});
}

@override
Expand Down Expand Up @@ -186,7 +192,9 @@ class _ScrollShadowState extends State<ScrollShadow> {

bool _handleNewMetrics(final ScrollMetrics metrics) {
if (_axis != metrics.axis) {
setState(() => _axis = metrics.axis);
scheduleMicrotask(() {
setState(() => _axis = metrics.axis);
});
}
reachedStart = metrics.pixels <= metrics.minScrollExtent;
reachedEnd = metrics.pixels >= metrics.maxScrollExtent;
Expand Down