Fix for issue 26: Default to CMakeLists.txt in current directory#35
Fix for issue 26: Default to CMakeLists.txt in current directory#35shanebishop wants to merge 1 commit intorichq:masterfrom
Conversation
|
The patch looks ok. I wonder though if this is good behavior in cases a project has split the build logic into multiple smaller .cmake files. The explicit command means when a file is not checked, it's the fault of the user. If we provide logic, it would become our fault. Did you consider this case, and consider to also scanning for |
|
@tkruse There are a couple things to consider:
|
|
I don't know myself. If the command is to try and guess the intention of a user who does not specify the file, we can only make reasonable assumptions and decide whether to be more bold or more conservative in including files. |
|
I think this is probably a reasonable default for now. |
|
copied to cmake-lint/cmake-lint#2 |
No description provided.