DO NOT MERGE: Final project code review#60
Open
mnfmnfm wants to merge 4 commits intorichjimdev:masterfrom
Open
DO NOT MERGE: Final project code review#60mnfmnfm wants to merge 4 commits intorichjimdev:masterfrom
mnfmnfm wants to merge 4 commits intorichjimdev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, I'm really impressed by your project. You picked the most important, useful features and stretch goals to implement, leading to a focused product that doesn't feel like it has pieces tacked on.
One thing that seemed off during your presentation was that there seemed to be confusion over where new results show up on the results page when there are previous results. Right now, they show up at the end, but there was confusion over maybe them showing up at the beginning? I did like that you talked about both successes and challenges during the project, which is always useful for your classmates to hear.
I also love the photoshop :)
The comments in your code are mostly slight nitpicks on things you could have done more cleanly: overall, you have really well-organized and well-documented code here.
Once everyone has gotten the chance to look at this PR, feel free to close it without merging, so it doesn't show up as a pending PR on the repo!