Open
Conversation
2 tasks
3 tasks
Contributor
Author
|
Hmm... the segfault on Travis seems to trace back to |
Contributor
Author
|
Also, I just remembered that even if the keys are different, the data might still be the same, which creates a race condition. I ran right into that Chesterton fence 😅. But we might still be able to save time by skipping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #80, some use cases of RDS
storrs require atomic writes, which depend on thescratchdirectory. However, writing to scratch and then moving the file creates a bottleneck on some systems, Windows in particular. This workflow spends a lot of time renaming tiny files, and the total runtime was around 104 seconds on my machine.The changes in this PR cut the total runtime down to about 50 seconds, and
file.rename()is no longer a bottleneck.I need to do more digging to make sure people can disable
scratchwithdrake, but since progress logging is different than it once was, I think it is worth a shot.