Open
Conversation
…s always full, pieces are always in the same order and are either on the board or in the hand)
…need of more refactoring)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the piece arrays on a State are stacks that start out empty and grow as pieces are added to the board. That means pieces will be in arbitrary orders, and if we need to know where (say) all the ants are, we either need to search through the entire array or cache references to ants elsewhere in State.
This branch changes State so that instead of growing as pieces are added to the board, the array starts full, and pieces are either on the board or in the hand (
piece.coords.q == IN_HAND). This enables us to store pieces in the same order for every state, and easily look up specific pieces or pieces types.(Branch is not ready to merge yet.)
Idea came from Pieces on the Chess Programming Wiki: