Add React 19 peer dep support#292
Open
cole-robertson wants to merge 1 commit intorichardgill:mainfrom
Open
Conversation
|
@cole-robertson is attempting to deploy a commit to the llm-ui Team on Vercel. A member of the Team first needs to authorize it. |
rokikon
reviewed
Jun 20, 2025
| }, | ||
| "peerDependencies": { | ||
| "react": "^18.0.0" | ||
| "react": ">=18.0.0 <20.0.0" |
There was a problem hiding this comment.
Wouldn't it be more explicit to use ^19.0.0? Consumers still could use older versions if they need to stay on React 18.
|
Yes please merge this as soon as possible. I'm literally running into this problem with React 19. Thank you 🙏 |
|
In your package.json add: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
If a consumer is on React 19, then they get an error about the React 18 peer dependency constraint.
What
This PR enables React 19 peer dep support for all llm-ui subpackages.
Testing
This seems to have no issues from my testing with React 19 compatibility.
Closes #288