Add support for drive strength, BCD and VBUS_Sense#19
Open
flatmush wants to merge 1 commit intorichardeoin:masterfrom
Open
Add support for drive strength, BCD and VBUS_Sense#19flatmush wants to merge 1 commit intorichardeoin:masterfrom
flatmush wants to merge 1 commit intorichardeoin:masterfrom
Conversation
Owner
|
Thanks for the PR! I'm not sure how generally useful setting |
|
If bcd_enable is not set, setting CBUS to BCD_Charger or BCD_Charger# makes the pin always tri-state. (I just figured it out after trying to use BCD_Charger and then implementing the bcd_enable setting logic myself.) In my opinion, the current behavior (not allowing the user to set bcd_enable) is a bug, since it makes it impossible to use BCD_Charger output on CBUS pins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making a games machine as documented here:
https://forum.odroid.com/viewtopic.php?t=33936
I've been programming the FT231X using your program which I've found very useful.
Since this device is aiming to be low power I needed to use the VBus_sense feature, so I had to implement that.
I'm using the Battery Charge Detect feature to determine when I can charge the battery at full speed so I implemented that.
I also added the options for drive strength since I needed to tweak those to get the chip working correctly with my reset line.
Hope you find these changes useful.