Open
Conversation
``node app`` wasn't working for me, ``node server`` seems to be correct.
Merge branch 'add-sd-to-average'
Update README.md
Add Heroku support
Add standard deviation to average calculation
Adding Dockerfile and docker-compose.yml for running as a container
reformat readme add docker installation and includes the CDN URL change into the code.
Make the 'roomfield' have focus when the site is opened (so one can immediately type a number) and make 'Join room' be triggered when pressing enter. The entire flow of joining a room can now be: * open url * type number * press enter
Facilitate joining room keyboard only
Don't show average until everyone votes
When non-numeric votes are present average and standard deviation was calculated incorrectly - basically displayed as `null`. This fix converts 1/2 and playing cards votes to numbers and reject other non-numeric votes. Don't show average when there is no data (e.g T-Shirt card deck).
Use node docker image as base and copy files from repo instead of git checkout. Allow local changes to be reflected in app run by docker-compose.
refactor: Improve docker development experience
fix: Calculate correct Avg and StdDev
Bumps [ejs](https://github.com/mde/ejs) from 0.7.1 to 3.1.5. - [Release notes](https://github.com/mde/ejs/releases) - [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md) - [Commits](https://github.com/mde/ejs/commits/v3.1.5) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [express](https://github.com/expressjs/express) from 2.5.10 to 4.17.1. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@2.5.10...4.17.1) Signed-off-by: dependabot[bot] <support@github.com>
…s-4.17.1 Bump express from 2.5.10 to 4.17.1
Bump ejs from 0.7.1 to 3.1.5
Sort votes based on their position in card deck just before revealing them.
feat: Sort votes before reveal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kudos for the tool. It is wonderfully simple and great to use with my teams. The room timing out helps us to move quickly through stories but not knowing when the timeout will happen can cause friction. Could you visualise a count down clock to timeout on screen?