Skip to content

feat(critters): improve animation parsing and font preloading#115

Closed
riceharvest wants to merge 1 commit intomainfrom
fix/issue-104
Closed

feat(critters): improve animation parsing and font preloading#115
riceharvest wants to merge 1 commit intomainfrom
fix/issue-104

Conversation

@riceharvest
Copy link
Copy Markdown
Owner

This PR addresses issue #104 by improving the critters package:

  • Improved animation declaration parsing in runtime.js to extract specific names rather than using lazy matching. Now only actual @Keyframes names that exist in the stylesheet are considered.
  • Enhanced font parsing to generate multiple type-specific preloads (e.g., font/woff2). The MIME type is derived from the CSS format() or inferred from file extension when not specified.
  • Removed unnecessary direct DOM property access (attribs) not required for css-select integration; replaced with getAttributeNames() method.

All tests pass.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@riceharvest
Copy link
Copy Markdown
Owner Author

Superseded by #104 which is closer to green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant