Skip to content

Fix Railtie and its requires #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ribose-jeffreylau wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Railtie and its requires #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f9dd55
Update require path to 'active_uuid' instead of 'activeuuid'
ribose-jeffreylau Mar 11, 2019
c4ffad2
Update railtie requires for connection patch application
ribose-jeffreylau Mar 11, 2019
1cb2cd3
spec: Test that require-ing 'railtie' would not cause errors
ribose-jeffreylau Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ source "http://rubygems.org"

# Specify your gem's dependencies in activeuuid.gemspec
gemspec
gem "activerecord", "~>5.0"

rails_version = "~>5.0"
gem "activerecord", rails_version
gem "rake", "< 11.0"

gem "codecov", require: false, group: :test
gem "railties", rails_version, require: false, group: :test
gem "simplecov", require: false, group: :test
4 changes: 3 additions & 1 deletion gemfiles/Rails-5_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ source "http://rubygems.org"

gemspec path: "../"

gem "activerecord", "~> 5.0.0"
rails_version = "~> 5.0.0"
gem "activerecord", rails_version

gem "codecov", require: false, group: :test
gem "railties", rails_version, require: false, group: :test
gem "simplecov", require: false, group: :test
4 changes: 3 additions & 1 deletion gemfiles/Rails-5_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ source "http://rubygems.org"

gemspec path: "../"

gem "activerecord", "~> 5.1.0"
rails_version = "~> 5.1.0"
gem "activerecord", rails_version

gem "codecov", require: false, group: :test
gem "railties", rails_version, require: false, group: :test
gem "simplecov", require: false, group: :test
4 changes: 3 additions & 1 deletion gemfiles/Rails-5_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ source "http://rubygems.org"

gemspec path: "../"

gem "activerecord", "~> 5.2.0"
rails_version = "~> 5.2.0"
gem "activerecord", rails_version

gem "codecov", require: false, group: :test
gem "railties", rails_version, require: false, group: :test
gem "simplecov", require: false, group: :test
1 change: 1 addition & 0 deletions gemfiles/Rails-head.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ gemspec path: "../"
gem "activerecord", github: "rails/rails"

gem "codecov", require: false, group: :test
gem "railties", github: "rails/rails", require: false, group: :test
gem "simplecov", require: false, group: :test
4 changes: 2 additions & 2 deletions lib/active_uuid/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
require "activeuuid"
require "active_uuid"
require "rails"

module ActiveUUID
class Railtie < Rails::Railtie
railtie_name :activeuuid

config.to_prepare do
ActiveUUID::Patches.apply!
require "active_uuid/connection_patches"
end
end
end
11 changes: 11 additions & 0 deletions spec/integration/railtie_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
require "spec_helper"

RSpec.describe "railtie" do
it "does not raise error on #require" do
action = -> {
require "rails"
require "active_uuid/railtie"
}
expect(action).to_not raise_error
end
end